loadWindowLayout is slow
Posted: Fri Jun 15, 2007 13:09
I use dynamic loading of new layouts but it is slow. Loading of layout with 38 controls last 0.2 second on relase build (1.2 second on debug). I did performance profiling and I found out that CEGUI is creting about 300 windows and for each window sets about 40 properties. So addProperty(Property* property) is called 12114 times.
Is there some possibility to speed up loading of layouts? Are all 40 properties necessary to add for each window?
I have one suggestion to speed up addProperty function:
old code:
new code:
Could somebody review and submit this code change?
Is there some possibility to speed up loading of layouts? Are all 40 properties necessary to add for each window?
I have one suggestion to speed up addProperty function:
old code:
Code: Select all
void PropertySet::addProperty(Property* property)
{
if (!property)
{
throw NullObjectException("The given Property object pointer is invalid.");
}
if (d_properties.find(property->getName()) != d_properties.end())
{
throw AlreadyExistsException("A Property named '" + property->getName() + "' already exists in the PropertySet.");
}
d_properties[property->getName()] = property;
}
new code:
Code: Select all
void PropertySet::addProperty(Property* property)
{
if (!property)
{
throw NullObjectException("The given Property object pointer is invalid.");
}
if (!d_properties.insert(PropertyRegistry::value_type(property->getName(),property)).second)
{
throw AlreadyExistsException("A Property named '" + property->getName() + "' already exists in the PropertySet.");
}
}
Could somebody review and submit this code change?
).