"CEGUI_BIDI_SUPPORT" never defined

[YaronCT]

Some places check whether "CEGUI_BIDI_SUPPORT" is defined, e.g. in "cegui/src/WindowRendererSets/Core/Editbox.cpp" in "FalagardEditbox::render":

Code: Select all

#ifdef CEGUI_BIDI_SUPPORT
    renderTextBidi(wlf, visual_text, text_area, text_offset);
#else
    renderTextNoBidi(wlf, visual_text, text_area, text_offset);
#endif

"CEGUI_BIDI_SUPPORT" is only defined in "Config.h.in":

Code: Select all

#cmakedefine CEGUI_BIDI_SUPPORT

However, it's never defined in the CMake files, therefore will never be defined in "Config.h", or anywhere. Shouldn't it be defined if and only if "CEGUI_USE_MINIBIDI" is true or "CEGUI_USE_FRIBIDI" is true?

[YaronCT]

Which also makes we wonder, if BiDi support is tested at all..?

[Ident]

I don't use it and never tested it. But I also changed nothing that could break it Feel free to fix it.