Page 2 of 2

Re: Cannot center align text

Posted: Fri Jan 06, 2017 15:55
by Ident
I think horizontally aligned titlebars are more typical. However, left/right aligned can make sense too.

The WindowsLook definitely had the goal of having the titles left-aligned, which goes along with how Windows windows by default do it. This is intentional and I would expect it to be this way. GlossySerpent also has it left-aligned and I would say this looks normal and expected.

Generally, I would agree that it is fine if this is hardcoded inside each Look N' Feel and no Property is provided. The alignment should be part of a consistent look carried through all FrameWindows of a single style and not something regularly altered from FrameWindow to FrameWindow inside an application - at least under normal circumstances.

I would say we have two options here:
1) Hardcode the alignment: This means effectively removing the VertFormatting and HorzFormatting property definitions from all TitleBars and retaining their defaults by using the default one directly in the TextComponent. Seems to be what you want?
2) Make the alignment properties native: Add them to the FalagardTitlebar class and therefore make them present everywhere - even if not used. PropertyDefinitions would become simple Properties then. This is more efficient and guarantees that the property is always there (seems to feed better into user expections, as it goes along with what Blackroot, the beautiful people, thought it would be like)

Disadvantage of the hardcoding option is that later-on people might start asking us how to set the alignment dynamically, since we cut a feature that has existed in previous versions for a long time. Let's ask CrazyEddie?

Re: Cannot center align text

Posted: Sun Jan 15, 2017 19:36
by Ident
After the internal dev team e-mail conversation we had, I believe we should leave things as they are currently (no property in LNF and no property in the FalagardTitlebar is present for the text formatting). The designer needs to set the formatting in the look and feel file. We should however document how a property can be added, basically exactly as blackroot showed us in their snippet.

Re: Cannot center align text

Posted: Mon Jan 16, 2017 08:56
by YaronCT
Sorry for the late response, family matters.

I agree that the alignment should b generally fixed in the look`n`feel. However I was also proposing to remove the property from look`n`feel files that currently do define it (only in branch "default"). What do u guys think of that?

Re: Cannot center align text

Posted: Mon Jan 16, 2017 22:40
by Ident
YaronCT wrote:Sorry for the late response, family matters.

No worries, although I actually did get a little worried the past days.

I agree that the alignment should b generally fixed in the look`n`feel. However I was also proposing to remove the property from look`n`feel files that currently do define it (only in branch "default"). What do u guys think of that?


Sure. I found the following two:
"SampleBrowserSkin/Titlebar"
"OgreTray/Titlebar"

Did I miss any?

Re: Cannot center align text

Posted: Mon Jan 16, 2017 23:08
by Ident
Btw, feel free to remove the properties as discussed, Paul (CrazyEddie) basically agreed to it already.

Re: Cannot center align text

Posted: Mon Jan 16, 2017 23:38
by YaronCT
Ok, I'll remove them then.