Page 1 of 1
[Solved] Bug: regular operation logs an error
Posted: Sun Jul 21, 2019 15:05
by niello
FontManager::destroyObject() logs a message with severity LoggingLevel::Error.
It is not critical itself, but user code might reimplement a Logger so that application shutdowns on error.
It is better to be changed to LoggingLevel::Informative like in SchemeManager::destroyObject.
Re: Bug: regular operation logs an error
Posted: Sun Jul 21, 2019 16:31
by Ident
I dont have an opinion about this, if you have a fix for it I will merge it
Re: Bug: regular operation logs an error
Posted: Mon Jul 22, 2019 04:41
by niello
May you just change Error to Informative here, please?
https://bitbucket.org/cegui/cegui/src/a ... #lines-305Too little change to make a PR.
Re: Bug: regular operation logs an error
Posted: Mon Jul 22, 2019 06:07
by Ident
Ok, but only because it's you
Fixed in changeset c4c212d1ea3b
Re: [Solved] Bug: regular operation logs an error
Posted: Mon Jul 22, 2019 06:38
by niello
Thanks)
Re: [Solved] Bug: regular operation logs an error
Posted: Mon Jul 22, 2019 08:40
by niello
I've noticed you changed logging level to Warning. Why do you want to warn user about font destruction? It happens in a CEGUI::System::destroy() and there is nothing wrong with it. On the other hand Warning typically means that something went wrong but we can live with it.
Let's keep it. I just want to understand is there a reason behind or should I fix it in one of upcoming patches?
Re: [Solved] Bug: regular operation logs an error
Posted: Mon Jul 22, 2019 19:28
by Ident
I just rushed through it and made a mistake. Feel free to change it.