Page 1 of 1

Direct3D9Texture::isPixelFormatSupported leak

Posted: Tue Sep 10, 2019 14:55
by tasa
Hello,

In function "Direct3D9Texture::isPixelFormatSupported" in Texture.cpp:

Code: Select all

LPDIRECT3D9 d3d;
d_owner.getDevice()->GetDirect3D(&d3d);


This code leaks because the d3d object is not released, which it should:

https://docs.microsoft.com/en-us/window ... etdirect3d

Thanks :)

Re: Direct3D9Texture::isPixelFormatSupported leak

Posted: Tue Sep 10, 2019 15:04
by Ident
Interesting, this one must be ancient. Could you make a pull request?

Re: Direct3D9Texture::isPixelFormatSupported leak

Posted: Tue Sep 10, 2019 15:12
by tasa
Well I guess it's not very important since the leak only happens when shutting down Direct3D9 which always happens at end of the program.

I don't use Github so I can't make a PR :(

Re: Direct3D9Texture::isPixelFormatSupported leak

Posted: Tue Sep 10, 2019 15:14
by Ident
You are lucky then, because we have not switched over to github yet:
https://bitbucket.org/cegui/cegui/pull-requests/