Using ScopedConnection

Discussion regarding the development of CEGUI itself - as opposed to questions about CEGUI usage that should be in the help forums.

Moderators: CEGUI MVP, CEGUI Team

User avatar
PeterNewman
Just popping in
Just popping in
Posts: 13
Joined: Wed Jan 12, 2005 12:06
Contact:

Using ScopedConnection

Postby PeterNewman » Wed Aug 16, 2006 05:23

Whenever I try to use ScopedConnection in 0.5.0 RC2, I'm trying to access the private member (the constructor).

Should this be private, or is there a missing public: at around line 93 of CEGUIEvent.h ?

User avatar
CrazyEddie
CEGUI Project Lead
Posts: 6760
Joined: Wed Jan 12, 2005 12:06
Location: England
Contact:

Postby CrazyEddie » Wed Aug 16, 2006 10:59

Hi Peter,

You are, of course, correct - there should be a public: at line 93 :) Thanks for pointing out the mistake, I'll commit a fix.

CE.

User avatar
PeterNewman
Just popping in
Just popping in
Posts: 13
Joined: Wed Jan 12, 2005 12:06
Contact:

Postby PeterNewman » Tue Aug 29, 2006 04:14

Also, should ~ScopedConnection() check d_connection before calling disconnect? Or better, disconnect (and connected) check d_connection.isValid() first? Since it is possible to create a default constructor ScopedConnection, which will create a default Event::Connection, which uses 0 pointers.

Also, RefCounted copy constructor should if(d_object) before calling addRef() ? (CEGUIRefCounted.h, line 71)

User avatar
CrazyEddie
CEGUI Project Lead
Posts: 6760
Joined: Wed Jan 12, 2005 12:06
Location: England
Contact:

Postby CrazyEddie » Tue Aug 29, 2006 08:16

Thanks for the heads up on those. I'll have a look and commit fixes where appropriate.


Return to “CEGUI Library Development Discussion”

Who is online

Users browsing this forum: No registered users and 1 guest