Page 1 of 1

Using ScopedConnection

Posted: Wed Aug 16, 2006 05:23
by PeterNewman
Whenever I try to use ScopedConnection in 0.5.0 RC2, I'm trying to access the private member (the constructor).

Should this be private, or is there a missing public: at around line 93 of CEGUIEvent.h ?

Posted: Wed Aug 16, 2006 10:59
by CrazyEddie
Hi Peter,

You are, of course, correct - there should be a public: at line 93 :) Thanks for pointing out the mistake, I'll commit a fix.

CE.

Posted: Tue Aug 29, 2006 04:14
by PeterNewman
Also, should ~ScopedConnection() check d_connection before calling disconnect? Or better, disconnect (and connected) check d_connection.isValid() first? Since it is possible to create a default constructor ScopedConnection, which will create a default Event::Connection, which uses 0 pointers.

Also, RefCounted copy constructor should if(d_object) before calling addRef() ? (CEGUIRefCounted.h, line 71)

Posted: Tue Aug 29, 2006 08:16
by CrazyEddie
Thanks for the heads up on those. I'll have a look and commit fixes where appropriate.