Small mem leak in GUI mk1 (0.300)

[DreadID4]

Here's a trivial memory leak I found in MultiColumnListWidget.cpp:

Code: Select all

/*************************************************************************
   Destructor
*************************************************************************/
MultiColumnListWidget::~MultiColumnListWidget(void)
{
   removeChildWindow(*d_header);
   removeChildWindow(*d_horzScroller);
   removeChildWindow(*d_vertScroller);

   delete d_header;
   delete d_horzScroller;
   delete d_vertScroller;

   delete d_sortColumnChangedCommand;
   delete d_headerSizedCommand;
}


Should be:

Code: Select all

/*************************************************************************
   Destructor
*************************************************************************/
MultiColumnListWidget::~MultiColumnListWidget(void)
{
   removeChildWindow(*d_header);
   removeChildWindow(*d_horzScroller);
   removeChildWindow(*d_vertScroller);

   delete d_header;
   delete d_horzScroller;
   delete d_vertScroller;

   delete d_sortColumnChangedCommand;
   delete d_headerSizedCommand;
   delete d_headerDblClickCommand; // *** added this
}

I just added the last delete, which is "delete d_headerDblClickCommand;".

I checked CVS to make sure that it was there as well, and it is there as well. Thanks again for the GUI system.

[CrazyEddie]

Thanks. That one must have slipped by me!

I'll get the fix into the CVS later today.

[CrazyEddie]

Fix is now in CVS.

Btw: I checked out "iauns" - you've done a lot of work since last I saw the project

Excellent stuff!

[DreadID4]

Thanks for the compliments crazy ed! Of course, I couldn't have done it w/ out the GUI system.