layout editor in vc7.1

[gcarlton]

Hi, I've just compiled the editor under vc7.1. I was pleased to see it pretty much compiled and ran first time. Also the new version doesn't save all the redudant abs/rel size info, which I'm happy with.

I've included the vc7.1 project files in a patch (in the main cegui patch area).

Also, a fair lot of warnings show up. I've cleaned them all up, except for the int/uint ones. For those ones I always use int and cast any uint to int immediately, but I don't know what your preference is for it, so I left it as is.

I also noticed one annoying bug that I fixed. When I load a data file (in my game directory), changing the resolution no longer works. This is because it calls init() but the working directory is no longer correct. In my build I query the current directory at startup and then reset the working directory to that whenever init() is called. Seems to work.

Those two code changes are bundled up into a cvs patch file, also in the main cegui patch area.

Is that the right place to submit this stuff?

PS: One more change that is useful, in ManagerDlg.cpp, the supportedProperty function should add this bool property:

Code: Select all

strProperty == (utf8*)"BackgroundEnabled" ||

[scriptkid]

Hi!

Thanks for the patches. I think it's the right place. However, if you want to contribute more often, it might be handier to give you access right. Just let me know...

I fixed a lot of warnings too, but cannot commit them yet, so there will be probably some conflicts in that area, but i'll sort them out.

The directory restoring is a good one, makes the application more robust!

About the properties, just add the ones you like, i'd say. Initially, i wanted to support the properties in "stages", of which the current set is actually still stage 1.

But i'll read through the list again and include some more, including the one you mentioned.

[CrazyEddie]

@scriptkid:
I'll give you permissions on the patch tracker, so you can close these items when you're done with them

I'm hoping that CVS access will be restored later today.

CE.

[scriptkid]

I've included the vc7.1 project files in a patch (in the main cegui patch area).

Do you know how to apply the patches to CVS? I tried to use GNU's "patch", but i can't get it to work... tries many combinations but get errors, "garbage" warnings and such...

Thanks in advance!

[gcarlton]

Hmm I just use TortoiseCVS to make patches up.. I did apply patches a while ago using some unixtools, but I've forgotten the exact commands. Perhaps there was some error in making the patch file up..

If you give me access I can just check them straight in to CVS. However, as I've made up most of my gui dialogs already I'm not going to be spending a great deal of time on the editor for a while, so I'm not going to be that active.

Alternatively, you could just ditch the patch, as the warning fixes are trivial, and the directory fix consists of a couple of lines of code which you can see by looking at the text of the patch file.