[PATCH] TreeEventArgs for Lua Script Module

If you found a bug in our library or on our website, please report it in this section. In this forum you can also make concrete suggestions or feature requests.

Moderators: CEGUI MVP, CEGUI Team

kripken
Not too shy to talk
Not too shy to talk
Posts: 27
Joined: Mon Aug 04, 2008 10:05

[PATCH] TreeEventArgs for Lua Script Module

Postby kripken » Fri Nov 28, 2008 18:38

Hi,

It appears that the Lua Script Module (in 0.6.1) is missing bindings for TreeEventArgs. Here is a patch which passes my tests:

Code: Select all

=== modified file 'ScriptingModules/CEGUILua/LuaScriptModule/package/HelperFunctions.pkg'
7a8,11
> function CEGUI.toTreeEventArgs(e)
>     return tolua.cast(e,"const CEGUI::TreeEventArgs")
> end
>
35a40
> CEGUI.EventArgs.toTreeEventArgs             = CEGUI.toTreeEventArgs

=== modified file 'ScriptingModules/CEGUILua/LuaScriptModule/package/InputEvent.pkg'
94a95,104
> /***********************************************************************
>    TreeEventArgs
> ***********************************************************************/
> class TreeEventArgs : public WindowEventArgs
> {
>    TreeItem *treeItem;
>
>    TreeEventArgs(Window* wnd);
> };
>


I apologize if this isn't the right place to post this, if so let me know where I should do so.

User avatar
CrazyEddie
CEGUI Project Lead
Posts: 6760
Joined: Wed Jan 12, 2005 12:06
Location: England
Contact:

Postby CrazyEddie » Sat Nov 29, 2008 13:19

Hi,

Thanks for the patch, I have added this as an eleventh hour addition for the 0.6.2 release.

A couple of things with regards to patches...
* It would be preferred if patches were in unified format.

* You can post small patches in the forum, though for anything more substantial (that would require more thorough testing), posting them on the mantis tracker (http://mantis.cegui.org.uk/) is preferable, since this way it's less likely to be lost or forgotten. Your forum login will also get to into mantis.

HTH, and thanks again for the patch ;)

CE

kripken
Not too shy to talk
Not too shy to talk
Posts: 27
Joined: Mon Aug 04, 2008 10:05

Postby kripken » Sat Nov 29, 2008 16:17

Ok, thanks for the clarifications. In the future I'll use the tracker, and standard diff format.

That's great news about this patch getting into 0.6.2, as (in addition to this other fix, which I see has also been committed) it means I will be able to use an unmodified CEGUI 0.6.2 for my project. Thanks! :)

User avatar
CrazyEddie
CEGUI Project Lead
Posts: 6760
Joined: Wed Jan 12, 2005 12:06
Location: England
Contact:

Postby CrazyEddie » Sat Nov 29, 2008 18:41

Just FYI: time permitting, we hope to get 0.6.2 released some time next week :)


Return to “Bug Reports, Suggestions, Feature Requests”

Who is online

Users browsing this forum: No registered users and 4 guests