[SOLVED]Combobox in TaharezLook

[Tiblanc]

Hi all!

I'm still very new to skinning and I was messing around with fonts and noticed my comboboxes were overlapping my new shiny font. I dug a bit in the looknfeel file and after the initial shock and awe, I think I figured out the problem. I'd like to ask more experienced skinners if there's a reason for this or it was because it felt right with the commonwealth font.

This is in the TaharezLook/Combobox, when defining the Height of the ComboEditbox child :

Code: Select all

                <Dim type="Height" >
                    <FontDim type="LineSpacing">
                        <DimOperator op="Multiply">
                            <AbsoluteDim value="1.5" />
                        </DimOperator>
                    </FontDim>
                </Dim>


When I look at the ComboEditbox definition, I see the top and bottom border are 5 pixels each. That would mean unless the font is at least 20 pixels high, the ComboEditbox will be too small to accommodate the borders and text, which means text gets cropped. After I replaced this multiply by an Add 10, the widget is correctly sized for all font sizes.

Is this correct or is there something I'm missing here?

Thanks!

[CrazyEddie]

Hi there,

Yes, I think you're right; I didn't look for myself yet (though I'm aware of the x1.5 thing), this appears to be an area that has potential to cause issues. I guess it's just one of those 'quick hack' solutions that never got cleaned up

Thanks,

CE.

[Tiblanc]

Ahhh, good old quick hacks that come back to haunt you

Thanks for the answer!