Kulik wrote:Well the one thing that is still undecided is whether it's OK to have the grid mapped to d_children....
I need to look into the implementation a bit closer and get back to you about this. Overall I'm someone who is happy to commit rough(ish) code now, and refine later if things become troublesome or a source of issues. Though I do, of course, appreciate the desire to get the best implementation early if possible.
Kulik wrote:I think introducing something like UBox would be better than 4 UDims, everything would be cleaner and more conscise. However UBox isn't the right name probably, but I can't think of anything better either UMargin sounds sketchy as well...
Jamarr wrote:As far as the best term to define a rectangular area having left, top, right, bottom properties - I cannot think of a term more fitting than "box" Also, as an incentive, the W3C calls it's margin, padding, border, and content areas the "Box Model."
Ok. I think we should go with UBox.
Kulik wrote:The problem with CEGUI::Size is, that it's 2 floats. I need two unsigned integers. But I guess I could probably round them or something...
Yeah. I think mostly it will be fine - who in their right mind would ask for 2.5 cells x 3.25 cells?
Kulik wrote:I've encountered a weird glitch that even though GridLayout set it's size correctly, ScrollablePane didn't update the scrollbar so you couldn't scroll all the way to the bottom. Can't reproduce it now though Really weird...
It's probably a ScrollablePane bug related to calculations regarding when a scrollbar is needed; It'll probably only show up when a pixel-perfect situation arises, once I get into some devel work, I'll see if I can trigger it.
Kulik wrote:Yeah and why aren't CEGUI::FrameWindows changing their size when they rollup? I know it's not necessary for rendering or anything, but with layouts it would make sense (even though I must confess having frame windows inside frame windows isn't probably the best use case of them). I could create CollapsibleBoxes with just looknfeel.
We used to have FrameWindow do this, and it was nasty (IMO) and required other hacks (like making the Titlebar not be clipped by parents). So when the client area / inner rect fix went in, I swapped to using a different type of hack instead. I will agree that the situation is not ideal, to date I'd been trying to work with the existing implementations and avoid the need to redesign the FrameWindow, though that may be the best solution in the long term (I've mentioned it lots of times over the years - it's one of a few parts of the system I'm really not happy with).
CE.