setFont broken in 0.8.7?

[BonneCW]

Hey there,

I'm working on a game engine based on Ogre and CEGUI for the graphics backend. I updated some time ago from CEGUI 0.8.4 to 0.8.7 and now using setFont doesn't have any effect anymore. Just setting the default font (CEGUI::System::getSingleton().getDefaultGUIContext().setDefaultFont(fontName)) takes effect, but of course I want to be able to set a specific font for widgets. Is anything known about this issue? Is there some other a workaround than going back to 0.8.4? Maybe the issue is caused by ticket #1087?

[YaronCT]

@BonneCW: Hi,

What type of widget?

[Ident]

Could you give us a minimal code snippet that safely reproduces the issue?

Even easier: If you can point out the issue anywhere in the samples browser's samples then point me to it, then I will fix the bug immediately.

Additionally, I want to say that the issue you linked me to was definitely visible in the SampleBrowser and I fixed it there without noticing any other changes and we definitely do set fonts for widgets there. So I am surprised to have missed this issue.

[BonneCW]

@BonneCW: Hi,

What type of widget?

It is a CEGUI::Listbox.

Could you give us a minimal code snippet that safely reproduces the issue?

Even easier: If you can point out the issue anywhere in the samples browser's samples then point me to it, then I will fix the bug immediately.

Additionally, I want to say that the issue you linked me to was definitely visible in the SampleBrowser and I fixed it there without noticing any other changes and we definitely do set fonts for widgets there. So I am surprised to have missed this issue.

I'll take a look on the samples, maybe I can reproduce the bug there. Otherwise I'll try to create a small sample with the bug. I don't think there is a basic configuration failure on my side as this feature worked for 2 or 3 years with different CEGUI versions and it also works again by just changing back to 0.8.4.

[YaronCT]

@BonneCW: No need, I've reproduced it and test it.

[YaronCT]

@BonneCW, @Ident: Seems like the bug is only in lists. I had noticed it b4 but just assumed it wasn't supposed to work, didn't know it was a regression..

[YaronCT]

That is, work with different fonts per list item.

[YaronCT]

@Ident: Your commit "4f90ed9e1c70" has caused this. If I try to undo the commit setting a list item font works again, but the sample framework doesn't. Do u by chance remember the reason for that commit?

[BonneCW]

@BonneCW: No need, I've reproduced it and test it.

Thanks. Good that you could reproduce it that fast.

[YaronCT]

@Ident: actually my mistake, the sample framework does work when reverting your commit. Is it possible u were on drugs when u made that commit?

[YaronCT]

@BonneCW: In the meantime, u can reverse the commit yourself: Install Mercurial, then:

Code: Select all

hg clo -u v0-8 https://bitbucket.org/cegui/cegui cegui
cd cegui
hg diff -r 4f90ed9e1c70^ -r 4f90ed9e1c70 --reverse | hg patch --no-commit -

[Ident]

Yes, the drags made me do it!

On a more serious note: I remember this change and there was a reason I did this. I don't remember the effect that removing it has but you should look very closely at the SampleBrowser especially in the look n feel sample to see if or what effect it has. Pretty sure there was something wrong. Also pretty sure that this tore open the bug you see. The solution has to be to fix both.