[Solved] Bug: regular operation logs an error

If you found a bug in our library or on our website, please report it in this section. In this forum you can also make concrete suggestions or feature requests.

Moderators: CEGUI MVP, CEGUI Team

niello
Quite a regular
Quite a regular
Posts: 67
Joined: Tue May 24, 2011 05:54
Contact:

[Solved] Bug: regular operation logs an error

Postby niello » Sun Jul 21, 2019 15:05

FontManager::destroyObject() logs a message with severity LoggingLevel::Error.
It is not critical itself, but user code might reimplement a Logger so that application shutdowns on error.
It is better to be changed to LoggingLevel::Informative like in SchemeManager::destroyObject.

User avatar
Ident
CEGUI Team
Posts: 1971
Joined: Sat Oct 31, 2009 13:57
Location: Austria

Re: Bug: regular operation logs an error

Postby Ident » Sun Jul 21, 2019 16:31

I dont have an opinion about this, if you have a fix for it I will merge it
CrazyEddie: "I don't like GUIs"

niello
Quite a regular
Quite a regular
Posts: 67
Joined: Tue May 24, 2011 05:54
Contact:

Re: Bug: regular operation logs an error

Postby niello » Mon Jul 22, 2019 04:41

May you just change Error to Informative here, please?
https://bitbucket.org/cegui/cegui/src/a ... #lines-305

Too little change to make a PR.

User avatar
Ident
CEGUI Team
Posts: 1971
Joined: Sat Oct 31, 2009 13:57
Location: Austria

Re: Bug: regular operation logs an error

Postby Ident » Mon Jul 22, 2019 06:07

Ok, but only because it's you ;)

Fixed in changeset c4c212d1ea3b
CrazyEddie: "I don't like GUIs"

niello
Quite a regular
Quite a regular
Posts: 67
Joined: Tue May 24, 2011 05:54
Contact:

Re: [Solved] Bug: regular operation logs an error

Postby niello » Mon Jul 22, 2019 06:38

Thanks)

niello
Quite a regular
Quite a regular
Posts: 67
Joined: Tue May 24, 2011 05:54
Contact:

Re: [Solved] Bug: regular operation logs an error

Postby niello » Mon Jul 22, 2019 08:40

I've noticed you changed logging level to Warning. Why do you want to warn user about font destruction? It happens in a CEGUI::System::destroy() and there is nothing wrong with it. On the other hand Warning typically means that something went wrong but we can live with it.
Let's keep it. I just want to understand is there a reason behind or should I fix it in one of upcoming patches?

User avatar
Ident
CEGUI Team
Posts: 1971
Joined: Sat Oct 31, 2009 13:57
Location: Austria

Re: [Solved] Bug: regular operation logs an error

Postby Ident » Mon Jul 22, 2019 19:28

I just rushed through it and made a mistake. Feel free to change it.
CrazyEddie: "I don't like GUIs"


Return to “Bug Reports, Suggestions, Feature Requests”

Who is online

Users browsing this forum: No registered users and 3 guests