Direct3D9Texture::isPixelFormatSupported leak

If you found a bug in our library or on our website, please report it in this section. In this forum you can also make concrete suggestions or feature requests.

Moderators: CEGUI MVP, CEGUI Team

tasa
Just popping in
Just popping in
Posts: 2
Joined: Tue Sep 10, 2019 14:53

Direct3D9Texture::isPixelFormatSupported leak

Postby tasa » Tue Sep 10, 2019 14:55

Hello,

In function "Direct3D9Texture::isPixelFormatSupported" in Texture.cpp:

Code: Select all

LPDIRECT3D9 d3d;
d_owner.getDevice()->GetDirect3D(&d3d);


This code leaks because the d3d object is not released, which it should:

https://docs.microsoft.com/en-us/window ... etdirect3d

Thanks :)

User avatar
Ident
CEGUI Team
Posts: 1964
Joined: Sat Oct 31, 2009 13:57
Location: Austria

Re: Direct3D9Texture::isPixelFormatSupported leak

Postby Ident » Tue Sep 10, 2019 15:04

Interesting, this one must be ancient. Could you make a pull request?
CrazyEddie: "I don't like GUIs"

tasa
Just popping in
Just popping in
Posts: 2
Joined: Tue Sep 10, 2019 14:53

Re: Direct3D9Texture::isPixelFormatSupported leak

Postby tasa » Tue Sep 10, 2019 15:12

Well I guess it's not very important since the leak only happens when shutting down Direct3D9 which always happens at end of the program.

I don't use Github so I can't make a PR :(

User avatar
Ident
CEGUI Team
Posts: 1964
Joined: Sat Oct 31, 2009 13:57
Location: Austria

Re: Direct3D9Texture::isPixelFormatSupported leak

Postby Ident » Tue Sep 10, 2019 15:14

You are lucky then, because we have not switched over to github yet:
https://bitbucket.org/cegui/cegui/pull-requests/
CrazyEddie: "I don't like GUIs"


Return to “Bug Reports, Suggestions, Feature Requests”

Who is online

Users browsing this forum: No registered users and 0 guests